ic-design-system icon indicating copy to clipboard operation
ic-design-system copied to clipboard

Add blank href attribute to ic-side-navigation 'app-icon' slot

Open gd2910 opened this issue 1 year ago • 4 comments

Summary of the bug

When viewing the IcSideNavigation examples on the Code or Guidance pages, if a user clicks the 'app-icon' they are sent back to the design system home screen.

🪜 How to reproduce

Tell us the steps to reproduce the problem:

  1. Go to the Side Navigation guidance
  2. Click on the 'app-icon' in the example
  3. Get directed back to the home page

📸 Screenshots or code

Adding a redundant href to IcSideNavigation will stop the redirect.

`<IcSideNavigation appTitle="ACME coffee shop" version="v0.0.7" status="Alpha" disableAutoParentStyling inline href="#"

`

Other examples on the Code page will also need to be changed.

🧐 Expected behaviour

Now when a user clicks the 'app-icon' they will not be redirected.

gd2910 avatar Mar 20 '24 12:03 gd2910

I'm going to work on this, do I need to have it assigned to me?

AlexVCS avatar Mar 20 '24 14:03 AlexVCS

Hi @AlexVCS, I've assigned you 👍 please reach out if you have any questions

GCHQ-Developer-530 avatar Mar 20 '24 15:03 GCHQ-Developer-530

Hey thanks @GCHQ-Developer-530, I am having issues running the project locally. Initially it said I had issues with the sharp module. I read this and got around that, but after running npm install --legacy-peer-deps npm start the last thing it says is compile gatsby files and it never opens up on my machine.

I wanted to test the changes I made. Is there a way around this so I can do that?

AlexVCS avatar Mar 20 '24 16:03 AlexVCS

Hi @AlexVCS, sometimes it helps to run npm run clean, and delete the node_modules folder and the package-lock.json before running npm install --legacy-peer-deps. If the issue persists, it might be worth doing an npm run build or npm run serve to see if either of those work. If not, let us know.

GCHQ-Developer-530 avatar Mar 21 '24 07:03 GCHQ-Developer-530