phpstan-drupal

phpstan-drupal copied to clipboard

Random false positive "Missing explicit access check on entity query"

4

I've been hitting some issues for a month or so where randomly after switching a branch I would see several "Missing explicit access check on entity query" reported. However, they're...

driskell

Probably a follow-up to the improvements that were made in https://github.com/mglaman/phpstan-drupal/pull/454... The following code is resulting in PHPStan error: "Missing explicit access check on entity query." ``` $query = $this->entityTypeManager->getStorage($entity_type)->getAggregateQuery()...

mstenta

``` class_alias('Drupal\Core\Http\KernelEvent', 'Symfony\Component\HttpKernel\Event\KernelEvent', TRUE); ``` Drupal provides this class alias to bridge to its own Event class to bridge from Component to Contracts with Symfony. However, this doesn't seem to...

mglaman

https://www.drupal.org/node/3212750 > The method Symfony\Component\HttpKernel\Event\KernelEvent::isMasterRequest() is deprecated in Symfony 5.3. The method has been replaced by Symfony\Component\HttpKernel\Event\KernelEvent::isMainRequest(). In Drupal 9 we are using Symfony 4. In Drupal 10 we are...

mglaman

Improve argument checks to constructor with `new static()`

2

## How to reproduce the issue: Make following change to Drupal core 10.1.x and run `./vendor/bin/phpstan analyze -c phpstan.neon core/modules/user/src/Form/EntityPermissionsForm.ph` command and it doesn't report missing parameter on create function....

KalleVuorjoki

PHPStan Drupal rules should emit messages consistent with the runtime deprecation message

4

Existing messages are missing information for humans (docs link) and processing code (upgrade_status, deprecation_status, Project Update Bot) alike. Eg. `Missing explicit access check on entity query.` (missing link, drupal version...

goba

Starts resolving #468

goba

Call to deprecated method loadRevision()/deleteRevision() of class Drupal\Core\Entity\EntityStorageInterface round 3

6

# Bug report ``` $ composer show mglaman/* mglaman/phpstan-drupal 1.2.1 Drupal extension and rules for PHPStan $ composer show phpstan/* phpstan/extension-installer 1.3.1 Composer plugin for automatic installation of PHPStan extensions...

mxr576

fixes #726

mglaman

Fixes #711

mglaman