phpstan-drupal icon indicating copy to clipboard operation
phpstan-drupal copied to clipboard

Published 20 hours ago • verified publisher icon mglaman

fix #147 Magic properties for FieldItemListInterface not detected

Open wallon-ines opened this issue 4 years ago • 2 comments

Fix Magic properties for FieldItemListInterface not detected #147

wallon-ines avatar Jul 05 '21 20:07 wallon-ines

Can we have a test? I'm concerned here as field item list implements that interface

mglaman avatar Jul 05 '21 20:07 mglaman

Can we have a test? I'm concerned here as field item list implements that interface

I just renamed tests/src/EntityTestClass.php in tests/src/EntityTest.php

wallon-ines avatar Jul 06 '21 00:07 wallon-ines

I think #244 fixed this. And the test class is outdated. I don't think the existing test coverage is perfect, and the existing test fixture has the same @todo comment, but I don't think it's being tested anymore. I've opened https://github.com/mglaman/phpstan-drupal/issues/723 to address this, which will hopefully uncover if https://github.com/mglaman/phpstan-drupal/issues/147 still exists.

mglaman avatar Feb 14 '24 02:02 mglaman