Meziantou.Xunit.ParallelTestFramework icon indicating copy to clipboard operation
Meziantou.Xunit.ParallelTestFramework copied to clipboard

Create an xunit v3 version

Open slang25 opened this issue 1 year ago • 3 comments

I've started adopting xunit v3, and would love to be able to use this package with it.

There are some changes, and I'm not sure how much change would be required outside of creating a separate package and adopting the new namespaces etc...

slang25 avatar Oct 29 '24 15:10 slang25

I think this is part of the xunit 3 roadmap, but not yet completed (https://github.com/xunit/xunit/issues/2133, https://github.com/xunit/xunit/issues/1986). Feel free to confirm it with xunit maintainers. So, maybe this package will be obsolete by then.

If it still needs custom code, it would be another package. One package for v2 and another one for v3. I hope most of the code will be shared, but we'll see when xunit is stable

meziantou avatar Oct 29 '24 17:10 meziantou

@meziantou any thoughts on updating this to support v3 now that its been released?

twurm avatar Feb 27 '25 16:02 twurm

There is no plan to update this package yet. The hope is that xUnit supports it natively. You can participate to the recent discussion to provide your input: https://github.com/xunit/xunit/discussions/3164

meziantou avatar Feb 27 '25 16:02 meziantou

What does it take to make this package support xunit v3?

rsgilbert avatar Jun 27 '25 21:06 rsgilbert

  • Update the dependencies
  • Fix all error issues (there are breaking changes)

meziantou avatar Jun 27 '25 21:06 meziantou

How about if we create a new package called Meziantou.XunitV3.ParallelTestFramework. In that way there wont be any breaking changes to affect xunit v1 and v2 users.

rsgilbert avatar Jun 27 '25 21:06 rsgilbert

That is the plan. We just need someone to create the PR ;)

meziantou avatar Jun 27 '25 21:06 meziantou

@bradwilson would you like to spend 2 hours and help convert + PR?

🙏🏻

PureKrome avatar Jun 29 '25 01:06 PureKrome

@PureKrome I wouldn't count on my having free time for this any time soon, unfortunately.

bradwilson avatar Jul 01 '25 00:07 bradwilson

Don't get too excited, but I think I've got everything upgraded here and it seems to be working 🙂

I'll tidy it up and create a PR later (probably tomorrow). Do we want a major version bump, or a side-by-side package with different name?

slang25 avatar Jul 06 '25 14:07 slang25

Great news! I think a new package is preferred, something like Meziantou.Xunit.v3.ParallelTestFramework

meziantou avatar Jul 06 '25 14:07 meziantou

+1 on the @meziantou naming suggestion.

PureKrome avatar Jul 06 '25 15:07 PureKrome

Thanks @slang25 for creating a PR! A new package is available to support xUnit v3: Meziantou.Xunit.v3.ParallelTestFramework

meziantou avatar Jul 07 '25 23:07 meziantou