metatype icon indicating copy to clipboard operation
metatype copied to clipboard

feat(meta-test): update `t.engine()` impl

Open destifo opened this issue 1 year ago • 2 comments

Update the implementation of t.enginei()

The change comes with removing the different spin-offs of t.engine which arose from the previous impl of t.engine incompatibility with artifact upload protocol. The change will make t.engine deploy the artifacts in Artifact Resolution mode by running a shell command to deploy the typegraph.

...

MET-500

  • [x] remove different versions of t.engine
  • [x] add tg_deploy caller script which imports typegraphs dynamically and deploys them.
  • [x] make changes to make t.engine run in artifact resolution mode
  • [x] update existing tests to adhere to the current change
  • [ ] pass unique different tempDirs to all the typegate instances created during test.

Migration notes

python SDK test typegraphs' function names should be the same with the filename of the typegraph file, for dynamic import compatibility reasons.

Summary by CodeRabbit

  • Refactor

    • Renamed functions for clarity:
      • wasm_wire_py to wasm_wire
      • test_error to error_message
      • testing to simple
    • Updated engine instantiation methods in test cases.
    • Adjusted function calls, object creation, and test assertions in Python and Wasm runtime tests.
  • Chores

    • Removed unused imports, variables, and deployment logic for cleaner code.

destifo avatar May 12 '24 21:05 destifo

Walkthrough

The recent updates in the Typegate project aim to refine test scripts and runtime configurations for WebAssembly and Prisma. Changes involve refactoring test setups, adjusting function signatures, error handling enhancements, and introducing new features for managing WebAssembly runtimes and Prisma settings.

Changes

File(s) Change Summary
typegate/tests/runtimes/wasm_reflected/wasm_sync_test.ts
typegate/tests/runtimes/wasm_wire/wasm_wire.py
typegate/tests/runtimes/wasm_wire/wasm_wire_test.ts
Refactored test scripts by removing unused imports, adjusting function calls, and updating logic for WebAssembly runtimes.
typegate/tests/runtimes/wasm_reflected/wasm_duplicate.py Introduced wasm_duplicate function for managing WebAssembly runtimes and exposing tests with specific policies.
typegate/tests/runtimes/wasm_reflected/wasm_reflected_test.ts Refactored test setup and execution logic for Wasm runtimes.
typegate/src/typegate/artifacts/mod.ts Added error handling with logging for the getLocalPath function.
typegate/tests/runtimes/prisma/normal_1_1.ts, typegate/tests/runtimes/prisma/optional_1_n.ts Modified function declarations to export constants awaiting the result of typegraph.
typegate/tests/utils/test.ts Updated ParseOptions interface, modified methods in MetaTest class, and added a new deployment method.
typegate/tests/utils/tg_deploy_script.py
typegate/tests/utils/tg_deploy_script.ts
Introduced scripts for deploying TypeGraph modules with specified configurations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 15 '24 08:05 coderabbitai[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.14%. Comparing base (cca3962) to head (a1118a0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #716      +/-   ##
==========================================
- Coverage   73.40%   73.14%   -0.27%     
==========================================
  Files         121      117       -4     
  Lines       14282    14141     -141     
  Branches     1419     1415       -4     
==========================================
- Hits        10484    10343     -141     
  Misses       3771     3771              
  Partials       27       27              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 15 '24 14:05 codecov[bot]