less-rails-bootstrap icon indicating copy to clipboard operation
less-rails-bootstrap copied to clipboard

Published 20 hours ago • verified publisher icon metaskills

Latest less-rails

Open veelenga opened this issue 7 years ago • 16 comments

Thanks a lot for maintaining this gem.

We use it in one of our production apps which is running on rails 4.2. Upgrading to the latest ruby/rails offers us to upgrade less-rails which is a dependency on less-rails-bootstrap.

This PR is about to upgrade this gem to the latest available less-rails:

https://github.com/metaskills/less-rails/compare/v2.8.0...v3.0.0

This addresses #131 and #130

I hope the PR is ok and you will be able to review/merge it ❤️

veelenga avatar Jan 15 '18 19:01 veelenga

👍

denqxotl avatar Jan 16 '18 15:01 denqxotl

👍

ghost avatar Jan 16 '18 15:01 ghost

@veelenga I took a look at the diff and it seems good to me. Since it has still been several months with no motion on this I'm going to suggest your build at gem 'less-rails-bootstrap', git: 'https://github.com/veelenga/less-rails-bootstrap', :ref => '7c479c2fdff500dc036c15364aa085332a73c642' for our use on our staging, pending eventual production deployment (Ruby 2.4.2, Rails 5.1.5). If we encounter any issues I'll post them here.

Thank you for all your work on this issue. Hopefully it is merged into master soon!

UPDATE For those considering using this, the above ref has been running solidly on one of our our production servers at roughly 150req/min since April 8 2018 with no issues.

Genkilabs avatar Mar 12 '18 18:03 Genkilabs

Anything the community can do to help get this merged @metaskills ?

NikoRoberts avatar May 06 '18 00:05 NikoRoberts

Hi @metaskills!

Can this PR merged, please?!

It will be very helpfully for many projects.

Thx

a-m-zill avatar Jun 21 '18 14:06 a-m-zill

@simi Any thoughts?

metaskills avatar Jun 21 '18 14:06 metaskills

If I understand well, we're dropping Rails 3.x and moving to less-rails 3.x resulting into new major release will be needed here. Am I right?

simi avatar Jun 22 '18 12:06 simi

Yes basically. We’re now using the PRed fork in production with Rails 5.1.

NikoRoberts avatar Jun 22 '18 13:06 NikoRoberts

Any chance to go ahead and get this merged and a new version pushed?

derekgottlieb avatar Oct 02 '18 13:10 derekgottlieb

Hi @simi @metaskills. Pilling on here to wonder if there's any possibility for this PR to merged and a new version to be published. My team would really love to see a new version that permits less-rails 3!

aergonaut avatar Sep 27 '19 19:09 aergonaut

I won't have time to help with this but if I need to grant access to someone then I certainly will. @simi are you working this gem anymore?

metaskills avatar Sep 27 '19 22:09 metaskills

Sure, I'm still around. I'll take a look.

simi avatar Sep 30 '19 16:09 simi

Seeing how this PR started 2 years ago my comment probably won't move the needle, but... any chance this can get merged in sometime soon @metaskills @simi?

@veelenga thanks for this fork.

ahwagner avatar Apr 16 '20 21:04 ahwagner

@metaskills Any chance on a tapping that juicy green merge button?

Genkilabs avatar May 11 '20 15:05 Genkilabs

Can @simi do that or someone a little more close to maintaining this project?

metaskills avatar May 11 '20 21:05 metaskills

:information_source: I'm around, but since this PR does more than just updating less-rails dependency, I need to spend some time on that, split the changes, and test (also with latest rails).

:thinking: If anyone around is able to open pull request updating just less-rails for now, it will be merged and released much faster.

simi avatar May 12 '20 08:05 simi