web3-smart-contracts icon indicating copy to clipboard operation
web3-smart-contracts copied to clipboard

feat: added a dynamic smart contract(Price Feed)

Open aviral727 opened this issue 3 years ago • 4 comments

Description

Created a smart contract which uses an oracle(chainlink price feed) for getting real time price of eth/usd

Fixes #9

Dependencies

chainlink contracts v0.8

Future Improvements

Further the contract can be made more intuitive and optimizations can be done

Mentions

NA

Screenshots of relevant screens

image

Developer's checklist

  • [x] My PR follows the style guidelines of this project
  • [x] I have performed a self-check on my work

If changes are made in the code:

  • [x] I have followed the coding guidelines
  • [x] My changes in code generate no new warnings
  • [] My changes are breaking another fix/feature of the project
  • [] I have added test cases to show that my feature works
  • [x] I have added relevant screenshots in my PR

aviral727 avatar Oct 26 '22 18:10 aviral727

Thank you for opening your first pull request in our repository, one of our maintainers will get in touch with you soon.

DO NOT FORGET TO ADD METAMASK WALLET ADDRESS IN THE AUTH FORM We at Metafy have some special rewards and swags for the top contributors in general repos and every contributor in web3 repos For being eligible for that, please authenticate yourself using this link: https://metafy.social/signup

Rewards : T-shirts & NFT ( for blockchain contributions )

Best of luck on your Contributions For further queries you can join our discord for support : https://discord.gg/W6PmEjjQsA

github-actions[bot] avatar Oct 26 '22 18:10 github-actions[bot]

PR is not linked to any issue, please make the corresponding changes in the body.

github-actions[bot] avatar Oct 26 '22 18:10 github-actions[bot]

Not quiet sure how is this dynamic. Would have preferred if you are sending the price from the connected app. Please explain your solution. Also please remove your hardcoded contract address and add a comment there

@advaita-saha please look into it

bartick avatar Oct 30 '22 16:10 bartick

@bartick I thought I just had to get data from an oracle for a dynamic contract. I may have misunderstood, any suggestions how I can rectify it?

aviral727 avatar Oct 30 '22 16:10 aviral727