metacpan-api icon indicating copy to clipboard operation
metacpan-api copied to clipboard

Indexing fails on giant modules

Open haarg opened this issue 8 years ago • 11 comments

https://metacpan.org/release/DCANTRELL/Number-Phone-3.4001 includes a module Number::Phone::UK::Data that is 96MB. This is binary content in a __DATA__ section. metacpan fails to index this file, eventually timing out. We should be able to detect content like this and skip the file, or at least time out on an individual file and continue with the rest of the dist.

haarg avatar Jul 04 '17 10:07 haarg

Ping @DrHyde (FYI)

oalders avatar Jul 06 '17 15:07 oalders

Ah. Curious, I could swear it was indexed in the past…

theory avatar Jul 06 '17 15:07 theory

It was. :) FWIW Number-Phone-3.4000.tar.gz does not time out.

oalders avatar Jul 06 '17 15:07 oalders

Pong!

I assume that it tipped over some limit in the most recent release. IIRC there was a similar problem a while back where it was trying to find POD in the __DATA__, so if you can find whatever the fix was for that you may be able to re-use it.

DrHyde avatar Jul 06 '17 15:07 DrHyde

Looks like Number::Phone::UK::Data was 65M in 3.4000. Any chance some buffer size could be temporarily increased to get this one release indexed, assuming @DrHyde switches to a sharedir in the next release? This is killing my build process. :-(

theory avatar Jul 20 '17 15:07 theory

That would be fine with me. @mickeyn any idea where we'd need to do this?

oalders avatar Jul 20 '17 16:07 oalders

if this is a one-off... i can hack something manually

mickeyn avatar Jul 20 '17 17:07 mickeyn

done. is it better now? https://metacpan.org/release/DCANTRELL/Number-Phone-3.4001

mickeyn avatar Jul 20 '17 17:07 mickeyn

Yep, thanks!

theory avatar Jul 20 '17 17:07 theory

FYI Number-Phone-3.4001_01 is on its way to the CPAN. Assuming that it doesn't break metacpan, and the CPAN testers are OK with it, that should mean that I've fixed it and the sharedir magic will be in the next non-dev release.

DrHyde avatar Jul 21 '17 21:07 DrHyde

3.4001_01 wouldn't build on Windows, 3.4001_02 does, and metacpan indexed it too.

DrHyde avatar Jul 27 '17 14:07 DrHyde