metabase icon indicating copy to clipboard operation
metabase copied to clipboard

VIZ-1048 - Only show compatible visualizer datasets

Open tsplude opened this issue 6 months ago • 3 comments

WIP PoC for VIZ-1048

Primary changes:

  • Uses /search endpoint instead of /recents
  • Moves 2 of 3 conditions we currently do in "tier 1" compatibility checking to be part of the search index filtering
    • exclude_display will have search filter out cards with :display "pie"
    • has_temporal_dimensions will have search filter out cards with/with out one or more temporal dimensions
  • Filters out incompatible items from sidebar

Local testing with appdb containing ~20k cards, where ~4k have temporal dimensions and ~2k are of display "pie" image

tsplude avatar Jun 06 '25 21:06 tsplude

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Snowplow tracking add database card should track visualizer related events Unable to find an element with the text "Orders by Product Category" after 4000ms. Logs ↗︎
scenarios > dashboard > visualizer > basics should allow clicking on the title Unable to find an element with the text "Products by Category" after 4000ms. Logs ↗︎
scenarios > dashboard > visualizer > funnels should build a funnel of several scalar cards The test timed out while trying to find an element with the text "Checkout Page" on the page. Logs ↗︎
scenarios > dashboard > visualizer > basics should allow editing a dashcard when added series are broken (metabase#22265, VIZ-676) Unable to find an element with the text "Invalid question" in the UI. Logs ↗︎

... and 8 more

Flaky Test Failure Summary Logs
e2e-storage-ingestion-test The expected and actual values are not equal, with a mismatch in the events list. Logs ↗︎
scenarios > dashboard > visualizer > filters should create and update a dashcard with 'Visualize another way' button Unable to find an element with the text "Products average by Category" in the UI. Logs ↗︎

View Full Report ↗︎Docs

trunk-io[bot] avatar Jun 06 '25 22:06 trunk-io[bot]

@cubic-dev-ai please review this PR

eliotmetabase avatar Jun 25 '25 21:06 eliotmetabase

@eliotmetabase I've started the AI code review. It'll take a few minutes to complete.

cubic-dev-ai[bot] avatar Jun 25 '25 21:06 cubic-dev-ai[bot]

👋 Deploying a preview environment for commit 07298f03bc78ae5a1b1fea3c853d6fd4d5e5a90f. ✅ Preview: https://pr59139.coredev.metabase.com 🗒️ login instructions

github-actions[bot] avatar Jul 16 '25 19:07 github-actions[bot]

e2e tests failed on 07298f03bc78ae5a1b1fea3c853d6fd4d5e5a90f-1

e2e test run

File Test Name
basics.cy.spec.ts scenarios > dashboard > visualizer > basics > should allow editing a dashcard when added series are broken (metabase#22265, VIZ-676)

github-actions[bot] avatar Jul 16 '25 19:07 github-actions[bot]