metabase
metabase copied to clipboard
VIZ-1048 - Only show compatible visualizer datasets
WIP PoC for VIZ-1048
Primary changes:
- Uses
/searchendpoint instead of/recents - Moves 2 of 3 conditions we currently do in "tier 1" compatibility checking to be part of the search index filtering
exclude_displaywill have search filter out cards with:display "pie"has_temporal_dimensionswill have search filter out cards with/with out one or more temporal dimensions
- Filters out incompatible items from sidebar
Local testing with appdb containing ~20k cards, where ~4k have temporal dimensions and ~2k are of display "pie"
| Failed Test | Failure Summary | Logs |
|---|---|---|
Snowplow tracking add database card should track visualizer related events |
Unable to find an element with the text "Orders by Product Category" after 4000ms. | Logs ↗︎ |
scenarios > dashboard > visualizer > basics should allow clicking on the title |
Unable to find an element with the text "Products by Category" after 4000ms. | Logs ↗︎ |
scenarios > dashboard > visualizer > funnels should build a funnel of several scalar cards |
The test timed out while trying to find an element with the text "Checkout Page" on the page. | Logs ↗︎ |
scenarios > dashboard > visualizer > basics should allow editing a dashcard when added series are broken (metabase#22265, VIZ-676) |
Unable to find an element with the text "Invalid question" in the UI. | Logs ↗︎ |
| Flaky Test | Failure Summary | Logs |
|---|---|---|
e2e-storage-ingestion-test |
The expected and actual values are not equal, with a mismatch in the events list. | Logs ↗︎ |
scenarios > dashboard > visualizer > filters should create and update a dashcard with 'Visualize another way' button |
Unable to find an element with the text "Products average by Category" in the UI. | Logs ↗︎ |
@cubic-dev-ai please review this PR
@eliotmetabase I've started the AI code review. It'll take a few minutes to complete.
👋 Deploying a preview environment for commit 07298f03bc78ae5a1b1fea3c853d6fd4d5e5a90f. ✅ Preview: https://pr59139.coredev.metabase.com 🗒️ login instructions
e2e tests failed on 07298f03bc78ae5a1b1fea3c853d6fd4d5e5a90f-1
| File | Test Name |
|---|---|
basics.cy.spec.ts |
scenarios > dashboard > visualizer > basics > should allow editing a dashcard when added series are broken (metabase#22265, VIZ-676) |