messense

Results 496 comments of messense
trafficstars

> 1. I believe we should vendor these logics - one is private, and the other requires the cargo package which i believe will add many dependencies to the project...

See also https://github.com/PyO3/maturin/issues/1081

Thanks @ariebovenberg, I think your approach of combining `setuptools-rust` and `maturin`/`maturin-action` is a viable way to implement pure python fallbacks.

* Parsing code can be added here: https://github.com/PyO3/maturin/blob/765915cc08fecb69ea11241eeb11d500cc01a7a6/src/pyproject_toml.rs#L110-L111 * We'd need to adjust wheel metadata here: https://github.com/PyO3/maturin/blob/765915cc08fecb69ea11241eeb11d500cc01a7a6/src/metadata.rs#L85-L92

Implementing `attr` support might be trick, ideally we don't want to depend on a working Python interpreter to such trivial task ([`ast.literal_eval`](https://docs.python.org/3/library/ast.html#ast.literal_eval)), but pulling in heavy dependencies like [`rustpython-parser`](https://crates.io/crates/rustpython-parser) increases...

See also https://github.com/scikit-build/scikit-build-core/issues/230

I think it's already possible by using `MATURIN_PEP517_ARGS` env var or `--config-settings`, for example ```bash pip wheel --config-settings=build-args='--features abi3-py312' ```

> Do you think support for something like "auto" abi3, where it used the current Python's version is possible? I think we can support this, we can change maturin to...

I'm not totally sure about this, please review this if you have time @konstin, thanks!

Thanks for reporting, definitely an oversight that should be fixed.