meson icon indicating copy to clipboard operation
meson copied to clipboard

Java module 1.0.0 updates

Open tristan957 opened this issue 3 years ago • 9 comments

tristan957 avatar Nov 17 '22 21:11 tristan957

This pull request introduces 1 alert when merging 3cc1823c81f7791978bc27ec75c991ffa919f97b into 0d3be23377c82f844aa7f9e9cb6074a8813400a4 - view on LGTM.com

new alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 17 '22 21:11 lgtm-com[bot]

Codecov Report

Merging #11071 (b3e39cb) into master (c876646) will decrease coverage by 1.40%. The diff coverage is n/a.

:exclamation: Current head b3e39cb differs from pull request most recent head dfea023. Consider uploading reports for the commit dfea023 to get more accurate results

@@            Coverage Diff             @@
##           master   #11071      +/-   ##
==========================================
- Coverage   68.02%   66.61%   -1.41%     
==========================================
  Files         414      207     -207     
  Lines       90016    44999   -45017     
  Branches    21278     9958   -11320     
==========================================
- Hits        61231    29975   -31256     
+ Misses      24149    12658   -11491     
+ Partials     4636     2366    -2270     
Impacted Files Coverage Δ
scripts/run_tool.py 0.00% <0.00%> (-100.00%) :arrow_down:
scripts/clangtidy.py 0.00% <0.00%> (-93.34%) :arrow_down:
templates/cstemplates.py 35.48% <0.00%> (-64.52%) :arrow_down:
scripts/coverage.py 0.00% <0.00%> (-64.36%) :arrow_down:
templates/javatemplates.py 36.66% <0.00%> (-63.34%) :arrow_down:
templates/rusttemplates.py 37.93% <0.00%> (-62.07%) :arrow_down:
templates/dlangtemplates.py 37.93% <0.00%> (-62.07%) :arrow_down:
templates/fortrantemplates.py 39.28% <0.00%> (-60.72%) :arrow_down:
scripts/clangformat.py 0.00% <0.00%> (-50.00%) :arrow_down:
modules/icestorm.py 57.14% <0.00%> (-40.00%) :arrow_down:
... and 260 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Nov 17 '22 22:11 codecov[bot]

I think a rebase on master will fix the website

dcbaker avatar Dec 02 '22 22:12 dcbaker

I did rebase prior to pushing

tristan957 avatar Dec 02 '22 22:12 tristan957

You're right! it's an actual error in the docs :/

dcbaker avatar Dec 02 '22 23:12 dcbaker

Oh yeah. I wasn't done migrating the docs to yaml. Whoops. I didn't know what the schema was for this kind of stuff. Is there a good example or a schema I can go read?

tristan957 avatar Dec 02 '22 23:12 tristan957

https://mesonbuild.com/Yaml-RefMan.html#yaml-schema

eli-schwartz avatar Dec 04 '22 01:12 eli-schwartz

Cool. I will get to work on this hopefully before the merge window :)

tristan957 avatar Dec 05 '22 16:12 tristan957

decided to just remove the yaml file for now. Will get to it at another time. Don't want to hold up a potential 1.0.0 release for it.

tristan957 avatar Dec 09 '22 22:12 tristan957

The test failures are weird. They seem unrelated but rerunning them did not make the errors go away,

D:\a\_temp\msys64\mingw64\lib\python3.10\site-packages\coverage\pytracer.py:290: 
CoverageWarning: Trace function changed, data is likely wrong: 
<bound method PyTracer._trace of <PyTracer at 0x1f16b29a020: 10671 lines in 109 files>> != <bound method PyTracer._trace
of <PyTracer at 0x1f164a23730: 10671 lines in 109 files>> (trace-changed)

jpakkane avatar Dec 10 '22 11:12 jpakkane

I don't know either

tristan957 avatar Dec 10 '22 18:12 tristan957

rebase didn't help. Sad

tristan957 avatar Dec 11 '22 04:12 tristan957

Actually it looks like the same tests are failing on master?

tristan957 avatar Dec 11 '22 04:12 tristan957

Should be all fixed with #11161

eli-schwartz avatar Dec 11 '22 18:12 eli-schwartz

Cool thanks. I will rebase when yours merges

tristan957 avatar Dec 11 '22 18:12 tristan957

Rebasing should fix this now.

jpakkane avatar Dec 11 '22 20:12 jpakkane

Failure is unrelated.

jpakkane avatar Dec 11 '22 23:12 jpakkane