meson icon indicating copy to clipboard operation
meson copied to clipboard

Iccrl78 support

Open gall1 opened this issue 3 years ago • 11 comments

Add support for IAR compiler for RL78 targets

gall1 avatar Oct 05 '22 07:10 gall1

This pull request introduces 1 alert when merging e18f24ddeca01a603f5800c19725ffa944c86242 into df1b95cf2b015fc5b756609f2cae1e0dc7176702 - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

lgtm-com[bot] avatar Oct 05 '22 07:10 lgtm-com[bot]

I would squash your commits and fix the warning ^. It might be nice to include a commit description and maybe a comment why only cross builds are supported

tristan957 avatar Oct 05 '22 18:10 tristan957

you'll also want to add a release snippet

tristan957 avatar Oct 05 '22 18:10 tristan957

This pull request introduces 1 alert when merging 767dd256360b307eec16cf0b424a13396763ff8d into b0eecda108708ce34ffcb97be7bc2b3ea64719de - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

lgtm-com[bot] avatar Oct 06 '22 07:10 lgtm-com[bot]

This pull request introduces 1 alert when merging c15c144ff7c47634f3afa4844da61f8d206840f6 into b0eecda108708ce34ffcb97be7bc2b3ea64719de - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

lgtm-com[bot] avatar Oct 06 '22 07:10 lgtm-com[bot]

This pull request introduces 1 alert when merging 6ef521ea606f1d1458e875001af51f8c277bfffe into 9add5d03b63b841dc437c9b0e9e2b8d43b96ea7c - view on LGTM.com

new alerts:

  • 1 for Conflicting attributes in base classes

lgtm-com[bot] avatar Oct 06 '22 14:10 lgtm-com[bot]

Codecov Report

Attention: Patch coverage is 38.93130% with 80 lines in your changes missing coverage. Please review.

Project coverage is 68.57%. Comparing base (df1b95c) to head (6ef521e). Report is 1863 commits behind head on master.

Files Patch % Lines
mesonbuild/compilers/mixins/iccrl78.py 42.10% 33 Missing :warning:
mesonbuild/compilers/c.py 34.28% 23 Missing :warning:
mesonbuild/linkers/linkers.py 53.57% 13 Missing :warning:
mesonbuild/compilers/detect.py 0.00% 8 Missing and 3 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10893      +/-   ##
==========================================
- Coverage   68.75%   68.57%   -0.19%     
==========================================
  Files         408      410       +2     
  Lines       86799    87073     +274     
  Branches    19198    19241      +43     
==========================================
+ Hits        59682    59713      +31     
- Misses      22656    22883     +227     
- Partials     4461     4477      +16     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 06 '22 14:10 codecov[bot]

Hi, I don't understand why checks failed on macos-clang and gccx64ninja. I see no relationship between thoses tests and my modifications... Your help is welcome :-)

gall1 avatar Oct 13 '22 15:10 gall1

I think those are both flaky tests, so I'm rerunning them to check.

eli-schwartz avatar Oct 13 '22 16:10 eli-schwartz

Still a flaky tests ? One more run needed ?

gall1 avatar Oct 14 '22 15:10 gall1

Hi, @gall1

I'm curious how you make IAR deal with assembly code with meson.

I have tried iccarm compiler with meson before but failed, and I find iccARCH can't compile assembly code directly, only iasmARCH can deal with assembly code.

Thanks.

mikisama avatar Nov 18 '22 14:11 mikisama