meson-python icon indicating copy to clipboard operation
meson-python copied to clipboard

Published 20 hours ago • verified publisher icon mesonbuild

CI: point action to codecov.xml as generated by pytest-cov

Open rgommers opened this issue 1 year ago • 1 comments

Addresses the issue in https://github.com/mesonbuild/meson-python/pull/657#issuecomment-2265481244

rgommers avatar Aug 02 '24 14:08 rgommers

Okay, that isn't it, no change. This broke something in the last 4 weeks says the dashboard for PRs:

image

It worked 4 weeks ago and doesn't work today, nothing changed on our side. There is zero useful logging in CI (it claims success) or in the dashboard. codecov-action didn't change in that time, and neither did pytest-cov. One `coverage release (7.6.0) but no relevant open issues. I'll park this for now.

rgommers avatar Aug 02 '24 14:08 rgommers

Does anyone know hot to get codecov unstuck?

@rgommers Should we switch to something else? coveralls.io seems to be another popular option.

dnicolodi avatar Oct 15 '24 17:10 dnicolodi

Maybe it fixed itself in the meantime and there's nothing left to do? The percentages are no longer missing and https://app.codecov.io/gh/mesonbuild/meson-python/commits looks like:

image

It seems like the code browser is also up to date again (https://app.codecov.io/gh/mesonbuild/meson-python/blob/main/mesonpy%2F__init__.py).

Should we switch to something else?

I rarely look at codecov, so I'd be fine with anything.

rgommers avatar Oct 15 '24 17:10 rgommers

I just look at the reports that pop up along the CI tests results. I haven't seen these working in a very long time. Therefore I thought codecov was still broken for us. Do you know how to get these back?

dnicolodi avatar Oct 15 '24 18:10 dnicolodi

Ah, in https://github.com/mesonbuild/meson-python/settings/installations I now see that the GitHub App is suspended, so that's probably why the notifications don't show up:

image

I don't know what happened though; it can only be re-enabled by an org owner. @jpakkane would you mind hitting the Configure button on that link and then the Update Access one on the next screen?

rgommers avatar Oct 15 '24 18:10 rgommers

We disabled codecov on the main repo because it was too spammy and not really helpful. Should be fixed now.

jpakkane avatar Oct 15 '24 21:10 jpakkane

Thanks @jpakkane! And definitely agree that Codecov is spammy by default - our config in this repo doesn't yield bot comments though, only a status check entry - so that's nice enough.

rgommers avatar Oct 16 '24 18:10 rgommers

I think everything is fixed; in the most recent push for gh-681 I see:

image

I'll close this PR.

rgommers avatar Oct 19 '24 06:10 rgommers