meson-python icon indicating copy to clipboard operation
meson-python copied to clipboard

Published 20 hours ago • verified publisher icon mesonbuild

TST: remove ninja from test dependencies

Open dnicolodi opened this issue 2 years ago • 3 comments

Now that meson-python can use the system provided ninja there is no need to depend on the PyPI package.

dnicolodi avatar Dec 09 '22 10:12 dnicolodi

This clearly needs some CI adjustment to install ninja, but I would like to know if there is consensus toward removing the dependency before doing that.

dnicolodi avatar Dec 09 '22 10:12 dnicolodi

I'm happy either way. Personally I use ninja from either the system package manager or conda-forge. I'm not using optional dependencies in pyproject.toml much.

rgommers avatar Dec 09 '22 10:12 rgommers

I thought about this because I added ninja to the Cirrus CI images but then I saw it gets downloaded one more time by the test setup when it runs python -m pip install .[test]. For sake of efficiency it would be better to use the system provided ninja and make sure it is installed in the CI runners, probably from the package manager on Linux and from Homebrew on macOS. I don't know what would be the best way to get it on Windows and Cygwin. Maybe PyPI?

dnicolodi avatar Dec 09 '22 11:12 dnicolodi