messenger-app-android icon indicating copy to clipboard operation
messenger-app-android copied to clipboard

Non-documented code

Open mradzinski opened this issue 6 years ago • 4 comments

Mesibo seems to be capable of much more other than sending messages and making video calls... but the code is not clear about it. You should evaluate documenting your code and perhaps writing a step-by-step document on how you built the demo app. As is, it's a mess to follow and understand the capabilities of your service.

mradzinski avatar Mar 01 '19 13:03 mradzinski

Thanks for the feedback. We suggest you look at https://mesibo.com/documentation/ and tutorials before driving into the Messenger app code. We will be happy to answer any question you have.

mesibo avatar Mar 01 '19 13:03 mesibo

As a matter of fact I did. Just as an example: Nowhere in the documentation mentions push notifications, which seem to be sent by Mesibo itself.

I've countless of other examples. The documentation lacks plenty of functionality which seems to be available but undocumented. Also, the SDK lacks JavaDocs, so basically there's no way for someone to know which method does which thing. There's also the need to document status codes and others...

I would say 50% is there, but there's another 50% which is not clear nor documented.

mradzinski avatar Mar 01 '19 13:03 mradzinski

Also, the detailed documentation in the api reference section here has documentation only for messages, no where can we find how to make calls, set up call connection, listeners for a call etc.

shahsurajk avatar Mar 19 '19 09:03 shahsurajk

Thanks, we are updating documents. In the meantime, we will be happy to help.

For Call Initialization, refer to https://github.com/mesibo/messenger-app-android/blob/master/app/src/main/java/org/mesibo/messenger/MainApplication.java#L70

  mCall = MesiboCall.getInstance();
  mCall.init(this);

This will initialize Mesibo call subsystem. It will also setup listener and you do not have to do anything extra.

Calls can be invoked by passing content, destination and video parameter as below

 MesiboCall.getInstance().call(context, Mesibo.random(), params.profile, true);

Let me know if you have more questions.

mesibo avatar Mar 19 '19 10:03 mesibo