python icon indicating copy to clipboard operation
python copied to clipboard

Fix for hopLimit param on sendTraceRoute not being respected

Open ppicazo opened this issue 1 year ago • 2 comments

If you use:

interface.sendTraceRoute(dest="!3b46b95d", hopLimit=5)

The hopLimit param specified is not used for the trace route as expected, the lora config hopLimit is used. This fix allows trace routes to be sent with a dynamic hop limit as the sendTraceRoute method definition would lead you to believe is possible.

ppicazo avatar Jul 02 '24 17:07 ppicazo

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 02 '24 17:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 02 '24 17:07 CLAassistant

I think this looks good; might be something we can extend to more functions, but for now keeping it on sendData is probably sufficient. It looks like pylint is complaining about something, so we can get that fixed and get this in!

ianmcorvidae avatar Jul 08 '24 02:07 ianmcorvidae

Codecov Report

:x: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 61.61%. Comparing base (0e6a0eb) to head (64bb668). :warning: Report is 506 commits behind head on master.

Files with missing lines Patch % Lines
meshtastic/mesh_interface.py 83.33% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #629      +/-   ##
==========================================
- Coverage   61.90%   61.61%   -0.30%     
==========================================
  Files          14       14              
  Lines        3019     3040      +21     
==========================================
+ Hits         1869     1873       +4     
- Misses       1150     1167      +17     
Flag Coverage Δ
unittests 61.61% <83.33%> (-0.30%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 10 '25 00:10 codecov[bot]