python icon indicating copy to clipboard operation
python copied to clipboard

feat:506 show all module settings

Open flavoromission opened this issue 1 year ago • 2 comments

Problem: Missing fields are omitted.

Solution: This fix sets the flag always_print_fields_with_no_presence in the invocation of the protobuff method MessageToJson will display the missing fields.

see: MessageToJson https://github.com/protocolbuffers/protobuf/blob/6b36eb633ccc9c585ed1ead117fca91702814027/python/google/protobuf/json_format.py#L82 see: issue #506 https://github.com/meshtastic/python/issues/506

flavoromission avatar Mar 18 '24 04:03 flavoromission

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 18 '24 04:03 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


flavor omission seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 18 '24 04:03 CLAassistant

This looks pretty reasonable to me, but we can't merge it without a signed CLA. If you can do that, I think I'd be happy to get this in.

ianmcorvidae avatar Mar 29 '24 18:03 ianmcorvidae

The PR should be all set @ianmcorvidae

flavoromission avatar Apr 02 '24 09:04 flavoromission

Excellent, thanks for signing that. I'll get this merged in, and thanks for the PR!

ianmcorvidae avatar Apr 02 '24 20:04 ianmcorvidae