firmware icon indicating copy to clipboard operation
firmware copied to clipboard

Update RadioLibRF95.cpp

Open kb9nate opened this issue 1 year ago • 4 comments

Two fixes.

  1. The #Define at the beginning of the file for the TCXO did not match what was used in the condition to enable the TCXO. Resulted in a compile error when trying to build with the TCXO enabled.

  2. In setFrequency the frequency variable was not being updated. This causes problems in SX1278.cpp for the getRSSI and errataFix functions

Thank you for sending in a pull request, here's some tips to get started!

(Please delete all these tips and replace with your text)

  • Before starting on some new big chunk of code, it it is optional but highly recommended to open an issue first to say "hey, I think this idea X should be implemented and I'm starting work on it. My general plan is Y, any feedback is appreciated." This will allow other devs to potentially save you time by not accidentially duplicating work etc...
  • Please do not check in files that don't have real changes
  • Please do not reformat lines that you didn't have to change the code on
  • We recommend using the Visual Studio Code editor along with the 'Trunk Check' extension (In beta for windows, WSL2 for the linux version), because it automatically follows our indentation rules and its auto reformatting will not cause spurious changes to lines.
  • If your PR fixes a bug, mention "fixes #bugnum" somewhere in your pull request description.
  • If your other co-developers have comments on your PR please tweak as needed.
  • Please also enable "Allow edits by maintainers".

kb9nate avatar Jul 18 '24 14:07 kb9nate

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '24 14:07 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '24 14:07 CLAassistant

@kb9nate can you trunk fmt and sign the CLA? Changes look good

thebentern avatar Jul 20 '24 11:07 thebentern

@kb9nate can you trunk fmt and sign the CLA? Changes look good

I don't know what "Trunk fmt" means. Not familiar with Trunk at all.

And I need to review the CLA closer. The part about signing over patent rights in particular.

kb9nate avatar Jul 20 '24 18:07 kb9nate

Hi @kb9nate , have you had a chance to look a the CLA? We can help with Trunk fmt if you need :)

fifieldt avatar Sep 17 '24 07:09 fifieldt

no response from OP, closing

caveman99 avatar Oct 02 '24 21:10 caveman99