Meshtastic-Android
Meshtastic-Android copied to clipboard
meshtastic
Initial Charts
Issue #559 seems relevant to this Pull Request.
I've implemented a first graph/chart for the device metrics as a start.
My plan is to address any valuable input anyone may have and based on those improvements we can plan the next steps.
My Concerns
- Anything wrong with the way I got the data?
Note: The data used for the chart below is not real.
I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.
I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.
nice progress - Pager w/ tabs or similar controls probably makes sense here. Found some guidelines (material 2 but seems relevant).
I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.
nice progress - Pager w/ tabs or similar controls probably makes sense here. Found some guidelines (material 2 but seems relevant).
Thanks, cool guide had not seen that yet.
I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.
sounds good.
I'd suggest working with protobufs directly instead of our POJOs (ie. com.geeksville.mesh.TelemetryProtos.EnvironmentMetrics instead of com.geeksville.mesh.EnvironmentMetrics)
as the POJOs will always behind (sometimes not available at all) for some telemetry variants.
I'm going to move forward with the Environmental Metrics chart. I was thinking about using a Pager that allows the user to swipe between graphs. Let me know if that works or if anyone has another suggestions.
sounds good.
I'd suggest working with protobufs directly instead of our POJOs (ie.
com.geeksville.mesh.TelemetryProtos.EnvironmentMetricsinstead ofcom.geeksville.mesh.EnvironmentMetrics)as the POJOs will always behind (sometimes not available at all) for some telemetry variants.
Makes sense.
The first iterations of graphs are ready for review. They still have room to improve but I would say its useful in it's current state.
Hi @Robert-0410,
How about adding the following features to the Device Metrics?
- Changeable timeframe: i.e. choose between history of one day, 3 days, one week of history
- choose what should be displayed: i.e. checkboxes for each sensor so you can unselect battery voltage and would see Channel and Air utilization with a better resolution
- add position to the history, ideally with a map and a track on it
Thanks, Chris
