meshery.io icon indicating copy to clipboard operation
meshery.io copied to clipboard

[UI] Navbar is not closing on click getting started in mobile view

Open amitamrutiya opened this issue 1 year ago • 7 comments

Description

In mobile view, when we click on "Getting Started," the navbar menu does not close.

Expected Behavior

In mobile view, the navbar should close when "Getting Started" is clicked.

Screenshots

image

Environment:

  • OS: Mac Linux Windows
  • Browser: Chrome Safari Firefox
  • Version:
  • Device: Desktop Mobile

Contributor Guides and Handbook

The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

amitamrutiya avatar Aug 25 '24 14:08 amitamrutiya

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Aug 25 '24 14:08 github-actions[bot]

Hi @amitamrutiya, could this be assigned to me. Would like to work on it

hymmns avatar Aug 25 '24 23:08 hymmns

Hi @amitamrutiya I want to work on this issue. Can you please assign it to me.

agamjotpanesar avatar Aug 26 '24 02:08 agamjotpanesar

@agamjotpanesar Thanks for showing interest in solving this issue. We are assigning tasks in chronological order, so you can find a different issue to work on.

@hymmns, you're good to go—let's make this happen!

amitamrutiya avatar Aug 26 '24 03:08 amitamrutiya

I managed to fix it with vanilla JS while testing in DevTools.

Tip The `display` of the navbar's ul needs to be set to _none_ once the _Getting Started_ li is clicked_.

Hope it helps :)

Please let me know if my behavior is ok. It's the first time I do this, and I thought it's ok as a tip since someone else has been already assigned. Thank you!

porobertdev avatar Aug 26 '24 18:08 porobertdev

@porobertdev Thanks for the input.

hymmns avatar Aug 27 '24 00:08 hymmns

@amitamrutiya Please let me know if this fixes the issue or if there's any other comment kindly drop.

hymmns avatar Aug 27 '24 01:08 hymmns

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Nov 10 '24 11:11 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Dec 04 '24 06:12 stale[bot]