meshery.io
meshery.io copied to clipboard
meshery
Added trademark in footer
Description
This PR fixes #1622
Notes for Reviewers
- [x] Yes, I signed my commits.
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | 96780e9043e6a3e5d67159e06328f0d4b4c1ed26 |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/6633e5977a48c70008cd7e58 |
| Deploy Preview | https://deploy-preview-1736--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploy Preview for mesheryio-preview ready!
| Name | Link |
|---|---|
| Latest commit | 39c77c40650112c0e2c89828dadc07445c909a8a |
| Latest deploy log | https://app.netlify.com/sites/mesheryio-preview/deploys/6642014cff7995000896a20e |
| Deploy Preview | https://deploy-preview-1736--mesheryio-preview.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@psankhe28 Let's discuss this on Websites's call. Add this as an agenda item into the meeting minutes, if you would :)
Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.
Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.
In the Slack channel, I inquired about which implementation to pursue, and based on the suggestions, I was advised to implement the one you can observe in the pull request.
But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.
But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.
https://layer5io.slack.com/archives/C015QJKUMPU/p1714659786470789
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
![stale[bot] avatar](https://avatars.githubusercontent.com/in/1724?v=4 "Published by a pub.dev verified publisher"){kind=small}
I wonder do we require this trademark? @psankhe28 are you still following up on this pr .
lets close this pr for now also Pratiksha is not responding so we will plan over it later. Thank you folks.