mergeable icon indicating copy to clipboard operation
mergeable copied to clipboard

validation fails on too big description

Open laughedelic opened this issue 3 years ago • 7 comments

HttpError: Invalid request.

Only 65535 characters are allowed; 184898 were supplied.

I have a bot updating description with some logs, so it gets quite big. ~~But the validation I have just checks that it's not empty, so I think it should work on a description of any size.~~

laughedelic avatar Nov 30 '21 01:11 laughedelic

Oh, I also had this validation:

      - do: description
        # All todo check boxes must be checked.
        must_exclude:
          regex: '- \[ \]'
          message: There are incomplete TODO task(s) unchecked

After removing it, no_empty works as expected.

laughedelic avatar Nov 30 '21 01:11 laughedelic

@laughedelic does it solve the issue you have?

shine2lay avatar Dec 02 '21 16:12 shine2lay

hi! this doesn't solve the issue. I just stopped using the buggy rule. the bug is that the regex rule fails on too big description.

it's not a big deal for me personally, but I think it's worth reporting this bug anyway. the limitation on the input size seems quite arbitrary (esp. since GitHub allows such big descriptions).

laughedelic avatar Jan 24 '22 18:01 laughedelic

@laughedelic IIRC, for too big of a content (incl. description), a separate github call is needed and we definitely have not implemented that yet. Thanks for reporting the bug.

shine2lay avatar Jan 24 '22 18:01 shine2lay

@shine2lay We are facing similar issues and would love to try to contribute Do you have any idea where the secondary call would be needed in such a case or what exactly would need to be touched?

hemeroc avatar Feb 24 '22 12:02 hemeroc

@shine2lay any ideas how we could support here.

hemeroc avatar Apr 06 '22 08:04 hemeroc

@hemeroc I think we you'll have to check if the response you want is giving the blob too big error, if so, you'll probably have to use this https://octokit.github.io/rest.js/v18#git-get-blob to fetch the data you need to process it.

shine2lay avatar Apr 06 '22 19:04 shine2lay