grpc-http-proxy icon indicating copy to clipboard operation
grpc-http-proxy copied to clipboard

🌟feat(responseTrailers): support for response header trailers added

Open keblodev opened this issue 6 years ago • 1 comments
trafficstars

  • plus GRPC_HEADER_METADATA_KEY_ID to config Grpc-Metadata headers key

Please read the CLA carefully before submitting your contribution to Mercari. Under any circumstances, by submitting your contribution, you are deemed to accept and agree to be bound by the terms and conditions of the CLA.

https://www.mercari.com/cla/

WHAT

Update allowing to receive back headers from the grpc call processing result. plus ability to specify Grpc-Metadata- header key for incoming headers using an environment variable instead of constant value. plus small updates to names as it was confusing to read the code a bit.

WHY

While translation is working great which is awesome! But the biggest issue for us when we were assessing the concept with your repo was the fact that we were not receiving any headers back from the rpc call result. Obviously the header trailers should be returned back to the caller, as they might contain new/updated data that client requires back.

keblodev avatar Dec 28 '18 08:12 keblodev

will update the tests over the weekend

keblodev avatar Dec 28 '18 09:12 keblodev