sudo-rs icon indicating copy to clipboard operation
sudo-rs copied to clipboard

Published 20 hours ago • verified publisher icon memorysafety

Test randomly fails

Open pvdrz opened this issue 2 years ago • 1 comments
trafficstars

I'm just opening this issue to keep track of it in case it happens again. CI was running for #212 and a test that shouldn't be affected by the changes of this PR failed: https://github.com/memorysafety/sudo-rs/actions/runs/4612410116/jobs/8153273441/ Then, I reran the failed job and all the tests passed https://github.com/memorysafety/sudo-rs/actions/runs/4612410116/jobs/8154338520

The test that failed is signal_sent_by_child_process_is_ignored.

pvdrz avatar Apr 04 '23 22:04 pvdrz

After checking the test it might be that this happens just due to the nature of how it works as it needs to sleep to give enough time to a signal delivery.

cc @japaric

pvdrz avatar Apr 04 '23 23:04 pvdrz

Is this still an issue? I haven't seen it happen in a while (but maybe I was lucky).

squell avatar May 31 '23 13:05 squell

I made some tests less brittle in #327 but didn't touch this one. I haven't seen this one fail in a long time either.

japaric avatar May 31 '23 13:05 japaric

Closing this as we have other CI problems and this one doesn't seem to be happening (re-open if it returns).

squell avatar Jun 06 '23 10:06 squell