mage Expand graph in path.subgraph_all when `filterStartNode == false`

Expand graph in path.subgraph_all when `filterStartNode == false`

Open thomas-tran-de opened this issue 6 months ago • 2 comments

Description

When filterStartNode == false, path.subgraph_all would always return the start node. However, it would not expand beyond it if it didn't meet the criteria in labelFilter. This is confusing as filterStartNode == false suggests that it will always be ignored. With this PR, it'll always expand beyond the start node.

In addition, using negative values for maxHops will now be ignored and use the default std::numeric_limits<int64_t>::max() instead.

Pull request type

[x] Bugfix
[ ] Algorithm/Module
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Related issues

This is related to #610 . To fix the issue, the documentation should be updated to highlight differences between DFS for path.expand/path.create and BFS for path.subgraph_all/path.subgraph_nodes.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

[ ] Core algorithm/module implementation
[ ] Query module implementation
[ ] Tests provided (unit / e2e)
[ ] Code documentation
[ ] README short description

Documentation checklist

[ ] Add the documentation label tag
[ ] Add the bug / feature label tag
[ ] Add the milestone for which this feature is intended
- If not known, set for a later milestone
[ ] Write a release note, including added/changed clauses
- [Release note text]
[ ] Link the documentation PR here
- [Documentation PR link]
[ ] Tag someone from docs team in the comments