mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Memory instance fails with langchain's graph provider

Open esoler-sage opened this issue 6 months ago • 2 comments

Memgraph class is not in the root anymore, so it needs to be imported from langchain_memgraph.graphs.memgraph

Description

Memgraph class is not in the root anymore, so it needs to be imported from langchain_memgraph.graphs.memgraph

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Refactor (does not change functionality, e.g. code style improvements, linting)
  • [ ] Documentation update

How Has This Been Tested?

Manual testing by fixing the code locally.

You can check it is not here (https://github.com/memgraph/ai-toolkit/blob/main/integrations/langchain-memgraph/langchain_memgraph/init.py) but in (https://github.com/memgraph/ai-toolkit/blob/main/integrations/langchain-memgraph/langchain_memgraph/graphs/memgraph.py). It can be changed to (https://github.com/memgraph/ai-toolkit/blob/main/memgraph-toolbox/src/memgraph_toolbox/api/memgraph.py) if preferred.

  • [x] Manual Test

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

esoler-sage avatar May 30 '25 09:05 esoler-sage

Fixes #2806, #2714

esoler-sage avatar May 30 '25 09:05 esoler-sage

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 30 '25 09:05 CLAassistant

When will this PR be merged?

Paddy420 avatar Jun 22 '25 17:06 Paddy420

Oh wow. It's been a month! Are there any issues?

pavelklymenko avatar Jun 27 '25 02:06 pavelklymenko

Closing as it's fixed already.

parshvadaftari avatar Sep 05 '25 12:09 parshvadaftari