mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

update ollama code to get model.model property instead of model.name

Open James-Pickett opened this issue 10 months ago • 3 comments

Changes started with this comment:

https://github.com/mem0ai/mem0/issues/2030#issuecomment-2625624175

Thank you @SailorJoe6

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Running locally with print statements.

Then running the tests in

  • tests/embeddings/test_ollama_embeddings.py
  • tests/llms/test_ollama.py

Sorry, I don't have time to figure out how to run full test suite.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] My changes generate no new warnings
  • [x] New and existing unit tests pass locally with my changes (at least in files mentioned above)
  • [x] Any dependent changes have been merged and published in downstream modules
  • [x] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

James-Pickett avatar Feb 02 '25 19:02 James-Pickett

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


jaypickle seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 02 '25 19:02 CLAassistant

Hey @James-Pickett Can you please check why tests are failing?

Dev-Khant avatar Feb 07 '25 09:02 Dev-Khant

Hey @James-Pickett Closing this PR as the solution is already incorporated. Thank you again for pointing it out!

parshvadaftari avatar Oct 10 '25 22:10 parshvadaftari