mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

Make limit configurable, add threshold

Open vsokolovskii opened this issue 1 year ago • 4 comments
trafficstars

Description

  • Limit is not configurable through the memory config
  • You can now set the custom similarity threshold to filter out irrelevant memories.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested with the local setup leveraging this package.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] I have checked my code and corrected any misspellings

Maintainer Checklist

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Made sure Checks passed

vsokolovskii avatar Aug 10 '24 14:08 vsokolovskii

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 10 '24 14:08 CLAassistant

@deshraj does this make sense to you? I think those parameters must be configurable, WDYT? If it makes sense I will update the documentation and write some test for this change

vsokolovskii avatar Aug 10 '24 14:08 vsokolovskii

@Dev-Khant any feedback will be valuable

vsokolovskii avatar Aug 12 '24 12:08 vsokolovskii

@vsokolovskii Changes looks good thanks for adding it. Can you please a test script where you have tested this? Thanks

Dev-Khant avatar Aug 13 '24 06:08 Dev-Khant

@vsokolovskii Can you please resolve the merge conflicts?

Dev-Khant avatar Jan 09 '25 11:01 Dev-Khant