mem0 icon indicating copy to clipboard operation
mem0 copied to clipboard

AWS Bedrock Embedder

Open andrewghlee opened this issue 1 year ago • 5 comments

🚀 The feature

Similar to AWS Bedrock llm, AWS Bedrock embedder should be made available. Some packages, like crewAI, just use embedchain app as a memory feature and only needs the embedder.

Motivation, pitch

Currently, embedchain does not have aws_bedrock embedder. Only the llm is available for AWS Bedrock. Requesting this feature as our team needs it as a dependency when using Bedrock with crewAI.

andrewghlee avatar Jul 12 '24 00:07 andrewghlee

I make a duplicate integration here https://github.com/embedchain/embedchain/pull/1472 but also update LLM code

hung-phan avatar Jul 12 '24 09:07 hung-phan

This is causing an issue for us as a downstream dependency in crewai.

With two open and unreviewed PRs addressing this, any idea when they will be reviewed @Dev-Khant?

brycecf avatar Jul 17 '24 14:07 brycecf

@brycecf Sorry for the delay here as we were busy with integrating Mem0. We will review these PRs on priority.

May I ask what problem are you facing in crewai because of this issue?

Dev-Khant avatar Jul 17 '24 15:07 Dev-Khant

@Dev-Khant crewAI has a memory feature that depends on embedchain's App, specifically the embedder is used to maintain the memory within a crew. Currently, this memory feature becomes unusable if AWS Bedrock embedding models are used, since AWS Bedrock embedder is not support yet (just Bedrock LLM is supported at the moment).

I believe my original PR request #1470 now has all issues resolved for the PR to go through and includes hung-phan's updates as well. Could you possibly kick off the workflow for the PR? :)

andrewghlee avatar Jul 24 '24 14:07 andrewghlee

@andrewghlee Thanks for explaining the issue with crewai, I'll review the PR soon and let you know.

Dev-Khant avatar Jul 25 '24 14:07 Dev-Khant