strapi-plugin-meilisearch icon indicating copy to clipboard operation
strapi-plugin-meilisearch copied to clipboard

Published 20 hours ago • verified publisher icon meilisearch

Workaround for locales

Open fhenri42 opened this issue 3 years ago • 5 comments

Pull Request

What does this PR do?

Fixes # 263 https://github.com/meilisearch/strapi-plugin-meilisearch/issues/263

PR checklist

Please check if your PR fulfills the following requirements:

  • [X] Does this PR fix an existing issue?
  • [X] Have you read the contributing guidelines?
  • [X] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

fhenri42 avatar Jun 24 '22 16:06 fhenri42

Hello @fhenri42! Thanks so much for your contribution 🙏 how does it look like when added to Meilisearch?

bidoubiwa avatar Jun 27 '22 12:06 bidoubiwa

Hello, you will not see any change in the UI, I juste added the "all" field to fetch all content-types and not only the default language. Maybe this change does not work if the plugin Internationalization is not installed, I will try to give you a answer before the end of the week. Do you think this option need to be set in the UI of the plugin ? Maybe I could set this as an options in the config file if that work for you ?

locales: ['fr', 'en, '*']

fhenri42 avatar Jun 27 '22 15:06 fhenri42

Hey @fhenri42 it could become a setting yes :) Let's see what your investigation brings up before going into that direction

bidoubiwa avatar Jun 28 '22 13:06 bidoubiwa

Hey @bidoubiwa I remove the Internationalization in a new app and did not have any issues

fhenri42 avatar Jun 28 '22 16:06 fhenri42

Any idea of when this MR will be approved?

Hedg0305 avatar Aug 09 '22 20:08 Hedg0305

Hey @Hedg0305

I think i'm going to move it to a setting to avoid unexpected behaviors to users not wanting this option. I'll keep you updated as soon as I come back on this pr :)

bidoubiwa avatar Sep 06 '22 15:09 bidoubiwa

Hey @fhenri42. I tried your suggested changes without having the @strapi/plugin-i18n plugin and it fails.

I'm trying to find if I can check its presence and depending on it add the local: 'all' to the request

bidoubiwa avatar Oct 06 '22 11:10 bidoubiwa

I found a work-around, since you are doing your changes on a main branch I can unfortunately not commit to it. I'm merging this PR in another branch to update it :)

Thanks for contributing !

bidoubiwa avatar Oct 06 '22 12:10 bidoubiwa

This message is sent automatically

Thank you for contributing to Meilisearch. If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

bidoubiwa avatar Oct 06 '22 12:10 bidoubiwa