meilisearch-symfony icon indicating copy to clipboard operation
meilisearch-symfony copied to clipboard

Use Symfony recipes

Open curquiza opened this issue 4 years ago • 2 comments

Docs: https://github.com/symfony/recipes/blob/master/README.rst

Related to:

  • https://github.com/meilisearch/meilisearch-symfony/issues/55#issuecomment-786641015
  • https://github.com/meilisearch/meilisearch-symfony/issues/55#issuecomment-826153870

curquiza avatar Apr 27 '21 16:04 curquiza

I already opened a PR at the symfony/recipes repository.

It currently fails because doctrine/orm is only a dev-requirement but actually is needed to be injected in the MeiliSearchImportCommand. This issue is tackled in PR #76.

codedge avatar Apr 27 '21 18:04 codedge

@codedge are we still waiting for https://github.com/symfony/recipes-contrib/pull/1188? :)

curquiza avatar Sep 14 '21 14:09 curquiza

Hello @curquiza, @brunoocasali

Would you still be interested in getting a recipe for the bundle? If so, I would be happy to submit a PR in the recipes-contrib repository!

ker0x avatar Mar 15 '23 07:03 ker0x

Hi, @ker0x yes that would be great! :D. Do you need anything from the Meilisearch side?

brunoocasali avatar Mar 15 '23 19:03 brunoocasali

Hello @brunoocasali

I have opened a PR: symfony/recipes-contrib#1494

If you or anyone else on the Meilisearch team can take a look and give feedback, it would be appreciated 👍.

ker0x avatar Mar 15 '23 20:03 ker0x

Well, that was quick, the PR was merged 😄!

You can close this issue 😉!

ker0x avatar Mar 16 '23 09:03 ker0x

Amazing, thanks @ker0x 🎉 🎉

brunoocasali avatar Mar 16 '23 16:03 brunoocasali