meilisearch-swift
meilisearch-swift copied to clipboard
Added public initializer for KeyParams.
Pull Request
Related issue
The KeyParams and KeysQuery structs do not have publicly accessible initializers. This implies that any code outside the MeiliSearch module cannot create new instances of these structs.
This works in direct contrast to examples laid out in the Meilisearch documentation such as when it displays constructing new KeyParams instances to pass to the POST /keys endpoint, which can be seen here, if you select Swift as the client language.
I've simply explicitly added a public initializers to both the KeyParams and KeysQuery structs.
bors try
Hello @mannuch Thanks for the PR! Looks like there is a linter issue. Could you fix it?
Hi @mannuch thanks for your contribution!!
I would like to know if you have any tips to test this behavior, so we can prevent that from happening again in the future.
Hi, @mannuch are you still interested in continuing working in this PR?
Yes I am! Sorry I've been busy the past couple weeks, but I will try to implement the necessary changes at the end of the week.
Thanks for your patience!
Thanks again for contributing to Meilisearch :heart: If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.