meilisearch-js icon indicating copy to clipboard operation
meilisearch-js copied to clipboard

Improve `HttpRequests`

Open flevi29 opened this issue 1 year ago • 1 comments

Pull Request

Sorry for the huge PR, but HttpRequests is core, and is used everywhere.

What does this PR do?

  • completely refactors http-requests.ts
  • fixes some EnqueuedTaskObjects not being converted to EnqueuedTask

[!CAUTION] BREAKING: From now on only some methods are public on HttpRequests (get, post, put, patch, delete), the rest of the properties and methods are internal implementation details, and are not meant to be directly accessed.

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

flevi29 avatar Oct 09 '24 10:10 flevi29