meilisearch-js icon indicating copy to clipboard operation
meilisearch-js copied to clipboard

Published 20 hours ago • verified publisher icon meilisearch

refactor: update clients to have different user agents

Open Botseer opened this issue 2 years ago • 5 comments

Pull Request

Related issue

Fixes #1437

What does this PR do?

The users agents for BrowserClient and NodeClient have been differentiated as per the issue for better metrics.

As for the code changes, I have made the change such that the necessary user agents are provided while constructing the respective client itself. Therefore there is no need to handle user agents in the http-request file.

PR checklist

Please check if your PR fulfills the following requirements:

  • [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [x] Have you read the contributing guidelines?
  • [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Botseer avatar Oct 27 '23 10:10 Botseer