Remove `public key` and `private key` wording

[curquiza]

Not a big deal, but we should remove the following wording

• private key
• public key

from our test (even the variable names if there are any) and any documentation.

Indeed, since MeiliSearch v0.25.0, private key is replaced by admin key and public key by search key.

[psvnlsaikumar]

@curquiza can you please clarify the below.

From what I understand, you mean to rename the variables from privateKey to adminKey, and publicKey to searchKey correct?

Example The below current code const privateKey = keys.find((key: Key) => key.description.startsWith('Default Admin API Key') )

The expected change in code const adminKey = keys.find((key: Key) => key.description.startsWith('Default Admin API Key') )

Please confirm if my understanding is correct, and I can start making changes. from the older issues which I have seen, the PRs are directly accepted, and there is no assignment of the issues to any individual. Is it still the same?

[curquiza]

Hello @psvnlsaikumar! Exactly, you get the issue! :)

Indeed, you don't need to be assigned, please open a PR when you have the time, thank you so much 🙂

[bidoubiwa]

Partially fixed by #1147

[Sukriti-m]

Hi @bidoubiwa I'd like to work on this issue. Please assign it to me.

[bidoubiwa]

Thanks for your interest in this project 🔥 You are definitely more than welcome to open a PR for this!

We prefer not assigning people to our issues because sometimes people ask to be assigned and never come back, which discourages the real volunteers contributors from opening a PR to fix this issue. We will accept and merge the first PR that fixes correctly and well implements the issue following our contributing guidelines.

We are looking forward to reviewing your PR 😊