Fix: Make SplitPlaneNormal.normal field optional

[CodeMan62]

Pull Request

Related issue

Fixes #119

What does this PR do?

• Refactors SplitPlaneNormal struct to use Option<T> for the normal field to properly handle potentially null values
• Updates test snapshots to reflect the new Option<T> structure
• Fixes failing tests:
  • add_one_item_incrementally
  • delete_extraneous_tree
  • delete_one_item
  • overwrite_one_item_incremental
  • reuse_node_id
  • write_and_update_lot_of_random_points

Testing Done

• All unit tests are now passing (53 passed, 1 ignored)
• All doc tests are passing (12 tests)
• Updated and verified snapshots using cargo insta test --accept
• Verified that the Option<T> wrapper properly handles the normal field in various test scenarios

PR checklist

Please check if your PR fulfills the following requirements:

• [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• [x] Have you read the contributing guidelines?
• [x] Have you made sure that the title is accurate and descriptive of the changes?

Let me know

[CodeMan62]

Hey @irevoire, Thanks for the review. I will do a rebase, then I will start working on it, but I have some things to do tomorrow, so I will start working on it by Thursday, and I will resolve the requested changes hope you understand

[irevoire]

Hey yeah don’t worry, take your time!

I’ll be on holiday next week anyway, so no pressure 👍

[CodeMan62]

I see that your PR is merged so i am closing it but i will keep finding potential issues to work on thanks for review @irevoire
Enjoy holidays!

[irevoire]

Hey, my pr is not solving the issue you were working on. You could totally rebase your pr on main if you wanted; I think you did a good chunk of the work already 👍

[CodeMan62]

Hey, my pr is not solving the issue you were working on. You could totally rebase your pr on main if you wanted; I think you did a good chunk of the work already 👍

I have reopened it I am gonna work on it thanks for this info

[CodeMan62]

@irevoire can you tell me that rebase is done or not I am bad at rebase if you can give me a confirmation that would be good

[CodeMan62]

rebase is done and i am working on your reviews work will be done asap EDIT:- @irevoire I see there is a lot of mistakes that I made sorry for that I am working on it and the PR will be resolved asap

[irevoire]

Hey @CodeMan62, I have to make progress quickly on this subject so I'll be taking it back for now.

Thanks a lot for the code you produced, it'll be a good starting base for me. I'll continue my work on your PR 😁

[CodeMan62]

@irevoire, I am really sorry for my inactivity on this :disappointed: . if you want we can split the work now I can work on it but we have to split the work?

[irevoire]

Hey, no, don't worry, you're already doing a ton of work everywhere on Meilisearch! We'll both be faster if we don't have to sync 😁

[CodeMan62]

Hey, no, don't worry, you're already doing a ton of work everywhere on Meilisearch! We'll both be faster if we don't have to sync 😁

No worry maintainer edits are allowed thanks

[irevoire]

Closing in favor of https://github.com/meilisearch/arroy/pull/127 and https://github.com/meilisearch/arroy/pull/125