remark-generic-extensions icon indicating copy to clipboard operation
remark-generic-extensions copied to clipboard

Nested generics with brackets like markdown image-inside-anchor

Open dustingetz opened this issue 7 years ago • 5 comments

Valid – regular markdown supports image nested in anchor

[![](https://i.imgur.com/oG4ni03.png)](http://www.hyperfiddle.net)

image nested in generic – Doesn't work but i think could be semantically valid

!list[![](https://i.imgur.com/oG4ni03.png)]()

generic nested in block-generic – valid

list:
:::
!value[](0 :todo/completed) !value[](0 :todo/title)
:::

The goal is generic nested in generic – doesn't work but could work?

!list[!value[](0 :todo/completed) !value[](0 :todo/title)]()

Here's a screenshot of what I'm doing image

dustingetz avatar Mar 30 '18 23:03 dustingetz

I'm not sure nesting inline extensions in inline extensions (or block in block) would be valid except in very specific cases. I don't know if / what the spec (in discussion) says about this.. Feel free to do a PR anyway, i'll put the feature behind an option if needed.

I designed this module for simple (components, widgets, perhaps layout) things, and i know there's clean ways to parse react jsx in the middle of markdown (i you want to do complex things) using the remark ecosystem, as done in phenomic, or other dialects.

medfreeman avatar Apr 22 '18 20:04 medfreeman

@medfreeman Will you accept this commit https://github.com/hyperfiddle/remark-generic-extensions/commit/ceb1e21fc2d779d0aa738d888bb68572ea796550? I think it is just a simple regex bug. image

dustingetz avatar May 09 '18 18:05 dustingetz

Sure, i'll take a look tomorrow. About all the issues you submitted, thanks. I don't mean to disrespect, but since i don't have much time, i'd appreciate if you'd make a simple repository / fiddle, possibly in plain js for the issues, so i could fix all your issues at once. The coffeescript? examples, sometimes with no precise explanation makes me having to take much time to comprehend the issues, that i'm sure i could fix very fast.

medfreeman avatar May 12 '18 20:05 medfreeman

Sorry, I never meant that you would have to fix these. I have a fork set up now so I will take a whack at fixing them as I come across them. Anything I can't fix I'll give you a better issue description or ask you a question. This extension is the best one, so I'll definitely try to invest more in it.

dustingetz avatar May 13 '18 00:05 dustingetz

Not a problem, that's not what is was implying ! I'd be happy to fix these issues. Thanks for the nice comments !

medfreeman avatar May 13 '18 18:05 medfreeman