CSRF-Protector-PHP icon indicating copy to clipboard operation
CSRF-Protector-PHP copied to clipboard

build failing for hhvm

Open mebjas opened this issue 8 years ago • 3 comments

Fatal error: f_xdebug_get_headers is not implemented yet. in 
/home/travis/build/mebjas/CSRF-Protector-PHP/test/csrfprotector_test.php on line 28
The command "phpunit --stderr --coverage-clover build/logs/clover.xml" exited with 255.

Error in travis-ci - https://travis-ci.org/mebjas/CSRF-Protector-PHP/jobs/221225373

mebjas avatar Apr 12 '17 08:04 mebjas

@oittaa - can you look into this?

mebjas avatar Apr 12 '17 08:04 mebjas

That version of HHVM doesn't have all the debug functions yet. Previously the builds were failing with the following: Fatal error: Call to undefined function xdebug_get_headers() in /home/travis/build/mebjas/CSRF-Protector-PHP/test/csrfprotector_test.php on line 28

I added a small fix for HHVM enabling xdebug, but the needed function was just a stub. We could try to figure out if there's another way to obtain headers.

oittaa avatar Apr 12 '17 09:04 oittaa

The hard way is to add a web server to the tests and do real requests against it. Then we could use get_headers().

oittaa avatar Apr 12 '17 09:04 oittaa