docker-ssh-exec icon indicating copy to clipboard operation
docker-ssh-exec copied to clipboard

Switching to ScaleFT/sshkeys for reading (encrypted) key data.

Open dhermes opened this issue 6 years ago • 1 comments

This is a follow-on to #7. A few notes:

  • There are no tests, what should I do to test this?
  • Should I update references to Go 1.9 to be Go 1.11?
  • To verify this is correct, should I run make.sh?
  • Where should I add the dependency on ScaleFT/sshkeys?

Thanks

dhermes avatar Jan 17 '19 07:01 dhermes

@benton Gentle nudge. I'd love to discuss / see what you have to say about the direction of this PR.

I initially thought the BEGIN OPENSSH PRIVATE KEY was just "Apple being Apple" but I realized it's a new format from the openssh maintainers:

The OpenSSH format, supported in OpenSSH releases since 2014 and described in the PROTOCOL.key file in the source distribution, offers substantially better protection against offline password guessing and supports key comments in private keys

dhermes avatar Feb 07 '19 05:02 dhermes