Add helper function for creating midsurface (a.k.a VLM) meshes
Purpose
Adds a helper function that uses a very similar approach to the fitted FFD generation code to generate a midsurface mesh of a wing, that can then be used in a VLM code. The generated meshes follow the camber line of each section of the wing, for example:
I added a test that uses a new input file that I added to the pygeo input files tarball
Expected time until merged
No rush
Type of change
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (non-backwards-compatible fix or feature)
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no API changes)
- [ ] Documentation update
- [ ] Maintenance update
- [ ] Other (please describe)
Testing
Checklist
- [ ] I have run
flake8andblackto make sure the Python code adheres to PEP-8 and is consistently formatted - [ ] I have formatted the Fortran code with
fprettifyor C/C++ code withclang-formatas applicable - [ ] I have run unit and regression tests which pass locally with my changes
- [ ] I have added new tests that prove my fix is effective or that my feature works
- [ ] I have added necessary documentation
Codecov Report
:x: Patch coverage is 93.87755% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.10%. Comparing base (cecefd2) to head (d91124a).
:warning: Report is 1 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pygeo/geo_utils/mesh_generation.py | 93.47% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #265 +/- ##
==========================================
+ Coverage 67.00% 67.10% +0.10%
==========================================
Files 47 48 +1
Lines 12331 12378 +47
==========================================
+ Hits 8262 8306 +44
- Misses 4069 4072 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Not sure what's happening with the docs build, I can't recreate it locally
Docs build failure should be fixed by https://github.com/mdolab/sphinx_mdolab_theme/pull/17
@ArshSaja can you please review this?