Updated view_user_cert to support all certificates.
Previously, this was working only for some specific certificates.
Can you please look at failing CI pipeline please?
Please rebase on the latest MOODLE_404_STABLE branch as I have bumped the Moodle Plugin CI version.
@mdjnelson rebased.
This is still failing. Please address the errors you can see at https://github.com/mdjnelson/moodle-mod_customcert/pull/681/checks.
Apologies. Initially I said I would address these but there are a few uncertainties about this patch. I would like this cleaned up so I can see a clear solution (right now it's touching code all over the place and im not sure why) at what is trying to be achieved. Please let me know when you are ready for me to re-review. Thanks.
Hi @mdjnelson, my apologies for bothering you, I have updated the title of this PR to [WIP], We'll let you know and will invite you to review this PR once this is ready.
@fulldecent @mdjnelson this is passing all checks and is working. This PR is good to review.
I've tried this PR, everything works great. However, is it possible to add option to not require token if option All can verify certificate is set true?
Well every certificate has a URL. And the URL has a token. That's the official public URL of the certificate. I don't think it makes sense to have a separate, additional public URL for certificates if a specific setting is turned on.
Looking now. Sorry for delay.
Can you respond to my comments or let me know if they have been addressed before I look at this again? Thanks.