moodle-mod_customcert icon indicating copy to clipboard operation
moodle-mod_customcert copied to clipboard

Updated view_user_cert to support all certificates.

Open Raza403 opened this issue 7 months ago • 11 comments

Previously, this was working only for some specific certificates.

Raza403 avatar May 01 '25 08:05 Raza403

Can you please look at failing CI pipeline please?

mdjnelson avatar May 01 '25 18:05 mdjnelson

Please rebase on the latest MOODLE_404_STABLE branch as I have bumped the Moodle Plugin CI version.

mdjnelson avatar Jun 23 '25 19:06 mdjnelson

@mdjnelson rebased.

Raza403 avatar Jun 24 '25 10:06 Raza403

This is still failing. Please address the errors you can see at https://github.com/mdjnelson/moodle-mod_customcert/pull/681/checks.

mdjnelson avatar Jul 06 '25 11:07 mdjnelson

Apologies. Initially I said I would address these but there are a few uncertainties about this patch. I would like this cleaned up so I can see a clear solution (right now it's touching code all over the place and im not sure why) at what is trying to be achieved. Please let me know when you are ready for me to re-review. Thanks.

mdjnelson avatar Jul 06 '25 11:07 mdjnelson

Hi @mdjnelson, my apologies for bothering you, I have updated the title of this PR to [WIP], We'll let you know and will invite you to review this PR once this is ready.

Raza403 avatar Jul 08 '25 17:07 Raza403

@fulldecent @mdjnelson this is passing all checks and is working. This PR is good to review.

Raza403 avatar Aug 05 '25 18:08 Raza403

I've tried this PR, everything works great. However, is it possible to add option to not require token if option All can verify certificate is set true?

indicozy avatar Aug 23 '25 01:08 indicozy

Well every certificate has a URL. And the URL has a token. That's the official public URL of the certificate. I don't think it makes sense to have a separate, additional public URL for certificates if a specific setting is turned on.

fulldecent avatar Aug 23 '25 05:08 fulldecent

Looking now. Sorry for delay.

mdjnelson avatar Aug 24 '25 13:08 mdjnelson

Can you respond to my comments or let me know if they have been addressed before I look at this again? Thanks.

mdjnelson avatar Oct 03 '25 20:10 mdjnelson