mdierolf
mdierolf
I added a .then() and .catch() function to Query which throws an error if they are used as if they are a promise, and a test-then-on-query.js unit test to confirm...
One thing to note: The proposed .transaction() function includes options that the current .beginTransaction() function does not currently accept. IMO, if .transaction() is going to accept options, then .beginTransaction() should...
I'd recommend leaving beginTransaction() for compatibility with mysqljs, and adding the following behavior: -Calling beginTransaction() will mark the Connection as having an open transaction -Calling commit() or rollback() will remove...
Any thoughts on this PR? I've been using it in production for a while, and updated it yesterday to be compatible with the new class-style code that is now in...
So we've been using this for the past year, it helps a little bit in simplifying our code, but I am thinking of re-designing this, as it doesn't really solve...
That did not work, after reading the code, this was the solution: const requester = request.execute(app).keepOpen();