ember-data-has-many-query icon indicating copy to clipboard operation
ember-data-has-many-query copied to clipboard

Published 20 hours ago • verified publisher icon mdehoog

Unnecessary dependancy on ember-cli-update

Open john-griffin opened this issue 6 years ago • 3 comments

Just installed 0.3.0 and it seems to add an unnecessary dependancy on ember-cli-update. This was noticeable because we use yarn and the lock file had a huge diff. Seems to have been introduced in this PR https://github.com/mdehoog/ember-data-has-many-query/pull/36 any reason for that?

john-griffin avatar Mar 13 '19 17:03 john-griffin

@RubenSmit any thoughts on this? Was added with https://github.com/martijnbolhuis/ember-data-has-many-query/commit/dfa52b87d45e00be3a8241f017c34a6bae736b74

mdehoog avatar Mar 13 '19 19:03 mdehoog

Whoops, that's indeed an unnecessary dependancy used to aid with updating. It should have been removed.

RubenSmit avatar Mar 19 '19 14:03 RubenSmit

Any update on removing this as yarn audit is showing tons of moderate security issues with ember-cli-update dep of dep

image

jrock2004 avatar Nov 06 '19 02:11 jrock2004