perfect-scrollbar icon indicating copy to clipboard operation
perfect-scrollbar copied to clipboard

Feature Request: eventListener set passive: false

Open Dev1lDragon opened this issue 5 years ago • 2 comments

change from:

114> this.element.addEventListener(eventName, handler, false);
[...]
124> this$1.element.removeEventListener(eventName, handler, false);

to:

114> this.element.addEventListener(eventName, handler, { passive: false });
[...]
124> this$1.element.removeEventListener(eventName, handler, { passive: false });

Dev1lDragon avatar Feb 06 '20 10:02 Dev1lDragon

Why false and not true?

https://github.com/mdbootstrap/perfect-scrollbar/issues/873 already requests the ability to set this via an option.

The guidance here is to use passive: true.

Splaktar avatar Dec 13 '20 04:12 Splaktar

Ah, the answer to that and the PR for this is here: https://github.com/mdbootstrap/perfect-scrollbar/pull/945#issuecomment-734504756

Splaktar avatar Dec 13 '20 04:12 Splaktar