pipedream icon indicating copy to clipboard operation
pipedream copied to clipboard

Published 20 hours ago • verified publisher icon mdbartos

Units for time?

Open michaeltryby opened this issue 6 years ago • 2 comments

@mdbartos Nice work!

I noticed in run.py that _dt=1e-6. What units are time in?

michaeltryby avatar Mar 26 '19 19:03 michaeltryby

Greetings,

Units are in seconds.

Keep in mind that the current code is very preliminary. I haven't reproduced the results for Ji's test case yet. I need to add some new code to handle cases where certain quantities (coefficients) are zero.

mdbartos avatar Mar 26 '19 20:03 mdbartos

Just thinking ahead. This algorithm is designed to be efficient, but requires a small time step for numerical stability. As a result the performance is somewhat lackluster. Trying to figure out how to make the time-step larger and improving performance would be something interesting you can look at that would constitute an original research contribution.

If you are interested.

michaeltryby avatar Mar 26 '19 20:03 michaeltryby