mcuboot
mcuboot copied to clipboard
sim: The upgrade/revert tests should use images having different sizes
Unless swap-move or overwrite-only upgrade strategies are used, the automatic tests executed in the simulator are configured to use two images of the same size for testing the upgrade and revert processes.
Indeed, the size of the images seems to be defined by this routine: https://github.com/mcu-tools/mcuboot/blob/f74b77cf7808919837c0ed14c2ead3918c546349/sim/src/image.rs#L2295-L2303
I agree it is a good thing to test the upgrade and revert processes with the largest possible images but I also think it important to that with two images having different sizes, since equally-sized images is very specific and uncommon scenario and testing only that scenario doesn't enable to detect issues such the one described by https://github.com/mcu-tools/mcuboot/pull/2109, occurring only when the two images have not exactly the same size.
This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.
Issue still present, could someone remove the stale label please?
This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.