mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

IAR compiler compatibility break in image.h

Open Karambite opened this issue 1 year ago • 1 comments

#ifndef __packed
#define __packed __attribute__((__packed__))
#endif

This is a compatibility break with IAR compiler. __packed is already a keyword that eliminates padding between members. This is not a definition, meaning it will always fall under the #ifndef. Any additions that uses __packed will be replaced by the definition given. Since this macro is targeted for GCC compiler, this should either be wrapped around a macro that checks if the compiler being used is GCC.

Karambite avatar Oct 15 '24 15:10 Karambite

Please submit a PR with the fix

nordicjm avatar Oct 16 '24 11:10 nordicjm

PR has been created

Karambite avatar Nov 19 '24 15:11 Karambite

New PR is https://github.com/mcu-tools/mcuboot/pull/2149

Karambite avatar Dec 16 '24 00:12 Karambite