mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

imgtool: Add tests for imgtool commands part 1

Open rustammendel opened this issue 1 year ago • 4 comments

Add various tests and improvements for imgtool commands

  • Add tests for sign command
  • Add tests for dumpinfo command
  • Add tests for verify command
  • Add more tests for key generation and derivation
  • Add pre-generated images and keys for testing
  • Move key unittests to tests/keys directory
  • Improve file input and error handling for some commands
  • Improve hex format support across commands
  • Refactoring and linting

rustammendel avatar Jun 21 '24 09:06 rustammendel

Please also update the cryptography dependency in scripts/setup.py:17

davidvincze avatar Jul 04 '24 11:07 davidvincze

Commit ded02c9 fixes issue 1846 and might be breaking for some users that use integer type custom TLVs.

rustammendel avatar Jul 23 '24 20:07 rustammendel

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar May 06 '25 02:05 github-actions[bot]

@rustammendel thanks for your effort!

This PR is open for a long time, what do you think, would it make sense to create a separate PR for the fix in imgtool dumpinfo for HEX files? (44e14a31f660cbf68a70ca508c2624d361e12675)

From my understanding this resolves #1976

This one is important for us. Like this I hope we'll be able to speed it up?

@kszromek-nordic

timonburkard avatar Jul 25 '25 06:07 timonburkard