mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

Published 20 hours ago • verified publisher icon mcu-tools

bootutil/crypto: Fix x25519 not compiling with mbedTLS

Open de-nordic opened this issue 1 year ago • 3 comments

Found on Zephyr wwhile trying to compile EDCSA25519 support with -DCONFIG_BOOT_ED25519_MBEDTLS=y, where compilation eneded up in errors.

It also seems that configuration has been dead for longer since the CMakeLists.txt has been needed to disable TinyCrypt source when mbedTLS is selected for ED25519.

This is addition to https://github.com/mcu-tools/mcuboot/pull/1937/, which addresses p256

de-nordic avatar May 28 '24 13:05 de-nordic

It seems to break Espressif that uses the internal module, different fix is needed for that. The https://github.com/mcu-tools/mcuboot/pull/1937 should be facing the same problem, but the CI does not run there.

Heh.. this PR breaks TinyCrypt... seems that CONFIG_BOOT_ED25519_TINYCRYPT=y requires mbedTLS for asn1...

de-nordic avatar May 28 '24 14:05 de-nordic

The CMake changes looks fine, I don't understand why you would need to remove the usages of MBEDTLS_CONTEXT_MEMBER.

utzig avatar Jun 20 '24 20:06 utzig

The ASN stuff got fixed here: https://github.com/mcu-tools/mcuboot/pull/1989

de-nordic avatar Jun 28 '24 10:06 de-nordic