mcuboot icon indicating copy to clipboard operation
mcuboot copied to clipboard

boot_serial: minor fixes in 'erase_range()' log output and for 'bs_list()'

Open pepe2k opened this issue 2 years ago • 2 comments

This short series includes 3 minor fixes for boot_serial:

  1. drop redundant parameters from bs_list() The buf and len parameters aren't used inside bs_list() function.

  2. boot_serial: include flash area offset in log info Currently, log info in erase_range() and bs_upload() shows range being erased/written relative to selected flash area which might be misleading. Include flash area offset in output so that the absolute addresses of the range being erased/written are shown.

  3. don't use %j length modifier with Zephyr's minimal libc The Zephyr's 'Minimal C library' doesn't support the %j length modifier when cbprintf is configured with minimum features.

pepe2k avatar Sep 08 '23 09:09 pepe2k

@nordicjm

Seems like the "Writing at ..." parts should be updated also

I've added that in second commit (boot_serial: include flash area offset in log info).

Thanks!

pepe2k avatar Sep 19 '23 10:09 pepe2k

Format needs updating for CI to pass

nordicjm avatar Sep 19 '23 12:09 nordicjm

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

github-actions[bot] avatar Jun 05 '24 01:06 github-actions[bot]